test(s2n-quic-core): add metric snapshot registry #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/metric-testing
branch
3 times, most recently
from
30c5bbc
to
1cfdfdb
Compare
camshaft
force-pushed
the
camshaft/metric-testing
branch
from
1cfdfdb
to
8b74fe3
Compare
Mark-Simulacrum
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
After all of the metrics being added, I wanted to add some snapshot tests to make sure they are being emitted into the future and don't have regressions. In this PR, this testing registry is integrated into the dc and pto tests.
Call-outs:
The rustls event order differ from s2n-tls. I've disabled snapshots for rusts for now and opening #2373 to track that work.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.